[Intel-gfx] [PATCH] drm/i915: Allow the user to override default firmware file names

Jani Nikula jani.nikula at linux.intel.com
Mon Feb 6 14:41:48 UTC 2017


On Mon, 06 Feb 2017, Chris Wilson <chris at chris-wilson.co.uk> wrote:
> Make the actual path we attempt to load for each of (DMC, GuC, HuC)
> overidable by the user. This helps testing new firmware releases.

And old firmware releases, and potentially helps bisect the kernel by
eliminating firmware changes.

> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> ---
>  drivers/gpu/drm/i915/i915_params.c      | 12 ++++++++++++
>  drivers/gpu/drm/i915/i915_params.h      |  3 +++
>  drivers/gpu/drm/i915/intel_csr.c        |  9 ++++++++-
>  drivers/gpu/drm/i915/intel_guc_loader.c |  4 ++++
>  drivers/gpu/drm/i915/intel_huc.c        |  8 ++++++++
>  5 files changed, 35 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c
> index f1fa51190dc6..d7001c0effa5 100644
> --- a/drivers/gpu/drm/i915/i915_params.c
> +++ b/drivers/gpu/drm/i915/i915_params.c
> @@ -243,3 +243,15 @@ MODULE_PARM_DESC(enable_dpcd_backlight,
>  module_param_named(enable_gvt, i915.enable_gvt, bool, 0400);
>  MODULE_PARM_DESC(enable_gvt,
>  	"Enable support for Intel GVT-g graphics virtualization host support(default:false)");
> +
> +module_param_named(dmc_firmware, i915.dmc_firmware_path, charp, 0400);
> +MODULE_PARM_DESC(dmc_firmare,
> +	"Provide an alternate name for the DMC firmware file");
> +
> +module_param_named(guc_firmware, i915.guc_firmware_path, charp, 0400);
> +MODULE_PARM_DESC(guc_firmare,
> +	"Provide an alternate name for the GuC firmware file");
> +
> +module_param_named(huc_firmware, i915.huc_firmware_path, charp, 0400);
> +MODULE_PARM_DESC(huc_firmare,
> +	"Provide an alternate name for the HuC firmware file");

Please make them _unsafe. With that,

Acked-by: Jani Nikula <jani.nikula at intel.com>


-- 
Jani Nikula, Intel Open Source Technology Center


More information about the Intel-gfx mailing list