[Intel-gfx] [PATCH 12/19] drm/i915: Remove bitmap tracking for used-ptes

Michał Winiarski michal.winiarski at intel.com
Mon Feb 6 20:32:31 UTC 2017


On Thu, Feb 02, 2017 at 03:02:41PM +0000, Chris Wilson wrote:
> We only operate on known extents (both for alloc/clear) and so we can use
> both the knowledge of the bind/unbind range along with the knowledge of
> the existing pagetable to avoid having to allocate temporary and
> auxiliary bitmaps.

We're losing the ability to effectively track the entries though (as in we can
no longer do 'for each !empty entry do stuff' without iterating through the
whole table), which is why we need to drop the info from the tracepoint.

It would be nice if we could find that in the commit message. Maybe with a
different wording :)

Either way:
Reviewed-by: Michał Winiarski <michal.winiarski at intel.com>

-Michał
 
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> ---
>  drivers/gpu/drm/i915/i915_gem_gtt.c | 338 ++++++++++++------------------------
>  drivers/gpu/drm/i915/i915_gem_gtt.h |   5 +-
>  drivers/gpu/drm/i915/i915_trace.h   |  19 +-
>  3 files changed, 121 insertions(+), 241 deletions(-)


More information about the Intel-gfx mailing list