[Intel-gfx] [PATCH i-g-t v2] tests: Clean up shell scripts

Joonas Lahtinen joonas.lahtinen at linux.intel.com
Tue Feb 7 10:06:32 UTC 2017


On ma, 2017-02-06 at 17:40 +0100, Daniel Vetter wrote:
> On Mon, Feb 06, 2017 at 03:25:27PM +0200, Jani Nikula wrote:
> > 
> > On Mon, 06 Feb 2017, Joonas Lahtinen <joonas.lahtinen at linux.intel.com> wrote:
> > > 
> > > Convert all scripts to use /bin/sh shebang and fix all shellcheck
> > > reported problems.
> > 
> > Pro-tip, this is the place reserved in commit messages for describing
> > *why* you think the change is needed or for the better. ;)
> 
> And this reply here seems to be the place where I'm asking why we don't
> switch to C if we go through all this effort. I don't really see what sh
> over bash buys us (and you can pretty much expect me to re-add bashism the
> next time around I touch these ...).

Oh, totally forgot due to writing the huge RFC e-mail about it. One
could amend the commit message with "to able to run on non-bash
shells.", if it wasn't yet merged.

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation


More information about the Intel-gfx mailing list