[Intel-gfx] [PATCH 11/19] drm/i915: Tidy gen6_write_pde()

Matthew Auld matthew.william.auld at gmail.com
Tue Feb 7 10:18:14 UTC 2017


On 2 February 2017 at 15:02, Chris Wilson <chris at chris-wilson.co.uk> wrote:
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> ---
>  drivers/gpu/drm/i915/i915_gem_gtt.c | 34 ++++++++++++----------------------
>  1 file changed, 12 insertions(+), 22 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
> index 991a15efe478..66c3540eb387 100644
> --- a/drivers/gpu/drm/i915/i915_gem_gtt.c
> +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
> @@ -1699,36 +1699,29 @@ static void gen6_dump_ppgtt(struct i915_hw_ppgtt *ppgtt, struct seq_file *m)
>  }
>
>  /* Write pde (index) from the page directory @pd to the page table @pt */
> -static void gen6_write_pde(struct i915_page_directory *pd,
> -                           const int pde, struct i915_page_table *pt)
> +static void gen6_write_pde(struct i915_hw_ppgtt *ppgtt,
> +                          const int pde, struct i915_page_table *pt)
Why doesn't this just take an unsigned int...

Reviewed-by: Matthew Auld <matthew.auld at intel.com>


More information about the Intel-gfx mailing list