[Intel-gfx] [PATCH 04/14] drm: Add DSI panel power on/off sequence programming

[Srinivas, Vidya]

> -----Original Message-----
> From: Jani Nikula [mailto:jani.nikula at linux.intel.com]
> Sent: Monday, January 9, 2017 3:54 PM
> To: Srinivas, Vidya <vidya.srinivas at intel.com>; intel-
> gfx at lists.freedesktop.org
> Cc: Srinivas, Vidya <vidya.srinivas at intel.com>
> Subject: Re: [Intel-gfx] [PATCH 04/14] drm: Add DSI panel power on/off
> sequence programming
> 
> On Mon, 09 Jan 2017, Vidya Srinivas <vidya.srinivas at intel.com> wrote:
> > Panel Power On/Off sequences are part of Panel spec.
> > Enabling the support of same in DRM layer for fine grained panel
> > control.
> 
> http://lkml.kernel.org/r/20160302152549.GA21035@ulmo.nvidia.com

Thanks Jani for pointing to the earlier upstream discussion. We will resend
the patch with the valid justifications added.

Regards
Vidya
> 
> >
> > Signed-off-by: Uma Shankar <uma.shankar at intel.com>
> > ---
> >  include/drm/drm_panel.h | 18 ++++++++++++++++++
> >  1 file changed, 18 insertions(+)
> >
> > diff --git a/include/drm/drm_panel.h b/include/drm/drm_panel.h index
> > 220d1e2b..515595b 100644
> > --- a/include/drm/drm_panel.h
> > +++ b/include/drm/drm_panel.h
> > @@ -69,6 +69,8 @@ struct drm_panel_funcs {
> >  	int (*disable)(struct drm_panel *panel);
> >  	int (*unprepare)(struct drm_panel *panel);
> >  	int (*prepare)(struct drm_panel *panel);
> > +	int (*power_on)(struct drm_panel *panel);
> > +	int (*power_off)(struct drm_panel *panel);
> >  	int (*enable)(struct drm_panel *panel);
> >  	int (*get_modes)(struct drm_panel *panel);
> >  	int (*get_timings)(struct drm_panel *panel, unsigned int
> > num_timings, @@ -166,6 +168,22 @@ static inline int
> drm_panel_enable(struct drm_panel *panel)
> >  	return panel ? -ENOSYS : -EINVAL;
> >  }
> >
> > +static inline int drm_panel_power_on(struct drm_panel *panel) {
> > +	if (panel && panel->funcs && panel->funcs->power_on)
> > +		return panel->funcs->power_on(panel);
> > +
> > +	return panel ? -ENOSYS : -EINVAL;
> > +}
> > +
> > +static inline int drm_panel_power_off(struct drm_panel *panel) {
> > +	if (panel && panel->funcs && panel->funcs->power_off)
> > +		return panel->funcs->power_off(panel);
> > +
> > +	return panel ? -ENOSYS : -EINVAL;
> > +}
> > +
> >  /**
> >   * drm_panel_get_modes - probe the available display modes of a panel
> >   * @panel: DRM panel
> 
> --
> Jani Nikula, Intel Open Source Technology Center