[Intel-gfx] [RFC/CI] drm/i915: Sanitize GuC client initialization

Chris Wilson chris at chris-wilson.co.uk
Fri Feb 10 14:36:39 UTC 2017


On Fri, Feb 10, 2017 at 03:30:10PM +0200, Joonas Lahtinen wrote:
> +static unsigned long __reserve_cacheline(struct intel_guc* guc)
>  {
> -	const uint32_t cacheline_size = cache_line_size();
> -	uint32_t offset;
> +	unsigned long offset;
>  
>  	/* Doorbell uses a single cache line within a page */
>  	offset = offset_in_page(guc->db_cacheline);

But unsigned long? I was trying to work out why we might need unsigned
long doorbell_offset, for when the doorbell object is of known size.

That's the only thing that stuck out like a sore thumb.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list