[Intel-gfx] [PATCH] drm/i915: Assert that the active request hasn't been signaled

Mika Kuoppala mika.kuoppala at linux.intel.com
Mon Feb 13 09:31:49 UTC 2017


Chris Wilson <chris at chris-wilson.co.uk> writes:

> As the request is not complete, it should not be signaled. Assert that
> this is true before we process the request for a reset.
>
> References: https://bugs.freedesktop.org/show_bug.cgi?id=99671
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>

Reviewed-by: Mika Kuoppala <mika.kuoppala at intel.com>

> ---
>  drivers/gpu/drm/i915/i915_gem.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
> index b8d869d7937d..48922ff454e6 100644
> --- a/drivers/gpu/drm/i915/i915_gem.c
> +++ b/drivers/gpu/drm/i915/i915_gem.c
> @@ -2611,6 +2611,8 @@ i915_gem_find_active_request(struct intel_engine_cs *engine)
>  			continue;
>  
>  		GEM_BUG_ON(request->engine != engine);
> +		GEM_BUG_ON(test_bit(DMA_FENCE_FLAG_SIGNALED_BIT,
> +				    &request->fence.flags));
>  		return request;
>  	}
>  
> -- 
> 2.11.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx


More information about the Intel-gfx mailing list