[Intel-gfx] [PATCH] drm/i915: Remove duplicate intel_logical_ring_workarounds_emit

Chris Wilson chris at chris-wilson.co.uk
Tue Feb 14 15:32:58 UTC 2017


On Tue, Feb 14, 2017 at 05:08:27PM +0200, Mika Kuoppala wrote:
> Tvrtko Ursulin <tursulin at ursulin.net> writes:
> 
> > From: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> >
> > intel_ring_workarounds_emit is exactly the same code.
> >
> > Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> 
> This was entertaining.
> 
> Reviewed-by: Mika Kuoppala <mika.kuoppala at intel.com>

Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>

Does somebody feel like taking the common code out of intel_ringbuffer.c
and moving it to intel_engine_cs?
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list