[Intel-gfx] [PATCH] drm/i915: The return of i915_gpu_info to debugfs

[Chris Wilson]

On Tue, Feb 14, 2017 at 05:00:35PM +0200, Mika Kuoppala wrote:
> Chris Wilson <chris at chris-wilson.co.uk> writes:
> > -static int i915_error_state_release(struct inode *inode, struct file *file)
> > +static int i915_gpu_info_open(struct inode *inode, struct file *file)
> >  {
> > -	struct i915_error_state_file_priv *error_priv = file->private_data;
> > +	struct drm_i915_error_state *error;
> >  
> > -	i915_error_state_put(error_priv);
> > -	kfree(error_priv);
> > +	error = i915_error_state(inode->i_private);
> 
> I kind of missed the verb here. And noticed the collision with
> other code. How about
> 
> error = i915_capture_gpu_state()?

Hmm. Yes, I agree it is better and I haven't thought of any better
myself.
 
> You could also add a token to error->error_msg as a notified
> that this is a gpu state from running situation to clearly
> separate these from the error states, if they get mixed up
> in bug reports.

They are distinguished atm by the hangcheck error state having an error
message. We could differentiate more, but that feels apt right now.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre