[Intel-gfx] [PATCH] drm/i915: Fix uninitialized return from mi_set_context

Chris Wilson chris at chris-wilson.co.uk
Tue Feb 14 15:40:22 UTC 2017


On Tue, Feb 14, 2017 at 03:29:01PM +0000, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> 
> For some reason my compiler (and CI as well) failed to spot the
> uninitialized ret in mi_set_context.
> 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> Fixes: 73dec95e6ba3 ("drm/i915: Emit to ringbuffer directly")
> Cc: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>

Ah, it was only because I don't have that redundant flush did my compile
spot the uninit ret.

Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list