[Intel-gfx] [PATCH 2/5] drm/i915: Simplify cleanup path in intel_engines_init

Chris Wilson chris at chris-wilson.co.uk
Thu Feb 16 13:15:26 UTC 2017


On Thu, Feb 16, 2017 at 12:23:22PM +0000, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> 
> We can call the engine cleanup vfunc instead of duplicating the
> decision making here.
> 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>

Ok, but dev_priv->gt.cleanup_engine() I still want to see removed at
some point. The paths are nearly identical that most can be done in
common, with the existing per-hw engine->cleanup() to cater for the
rest. Or everything is just done from engine->cleanup() as the entry
point.

Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list