[Intel-gfx] [PATCH] drm/i915: Assert that the request->tail is always qword aligned

Michał Winiarski michal.winiarski at intel.com
Mon Feb 20 13:45:30 UTC 2017


On Fri, Feb 17, 2017 at 04:38:33PM +0000, Chris Wilson wrote:
> The hardware requires that the tail pointer only advance in qword units,
> so assert that the value we write is aligned to qwords, and similarly
> enforce this restriction onto the request->tail.
> 
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> Cc: Mika Kuoppala <mika.kuoppala at linux.intel.com>

LGTM.
Quick grep confirms that those are indeed all the relevant spots where we're
updating req->tail.

Reviewed-by: Michał Winiarski <michal.winiarski at intel.com>

> ---
>  drivers/gpu/drm/i915/intel_lrc.c        | 4 ++++
>  drivers/gpu/drm/i915/intel_ringbuffer.c | 3 +++
>  2 files changed, 7 insertions(+)


More information about the Intel-gfx mailing list