[Intel-gfx] [PATCH] drm/fb: Proper support of boundary conditions in bitmasks.

Joonas Lahtinen joonas.lahtinen at linux.intel.com
Tue Feb 21 15:04:26 UTC 2017


On ma, 2017-02-20 at 10:00 +0200, Jani Nikula wrote:
> On Fri, 17 Feb 2017, Tomasz Lis <tomasz.lis at intel.com> wrote:
> > 
> > The recently introduced patch changed behavior of masks when
> > the bit number is negative. Instead of no bits set, the new way
> > makes all bits set. Problematic patch:
> >   drm/i915: Avoid BIT(max) - 1 and use GENMASK(max - 1, 0)
> 
> For future reference, please find the commit id of the committed patch,
> and reference that with the Fixes: tag. Please Cc the folks from the
> commit.
> 
> Whoever commits this must add:
> 
> Fixes: 3c779a49bd7c ("drm/i915: Avoid BIT(max) - 1 and use GENMASK(max - 1, 0)")
> Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Daniel Vetter <daniel.vetter at intel.com>
> Cc: Jani Nikula <jani.nikula at linux.intel.com>
> 
> Joonas, Chris, please check the rest of the regressing commit that it
> doesn't suffer from the same issue.
> 
> Thanks,
> Jani.

This line was actually rest of the commit. So all good, thanks for
catching this.

Reviewed-by: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation


More information about the Intel-gfx mailing list