[Intel-gfx] [PATCH 05/10] drm/i915/uc: Introduce intel_uc_init_fw()
Joonas Lahtinen
joonas.lahtinen at linux.intel.com
Mon Feb 27 12:09:52 UTC 2017
On pe, 2017-02-24 at 16:39 +0100, Arkadiusz Hiler wrote:
> Instead of calling intel_guc_init() and intel_huc_init() one by one this
> patch introduces intel_uc_init_fw() function that calls them both.
>
> Called functions are renamed accordingly.
>
> Trying to have subject_verb_object ordering and more descriptive names,
> the intel_huc_init() and intel_guc_init() functions are renamed.
>
> For guc_init():
> * `intel_guc` is the subject, so those functions now take intel_guc
> structure, instead of the dev_priv
> * init is the verb
> * fw is the object which better describes the function's role
>
> huc_init() change follows the same reasoning.
>
> v2: settle on intel_uc_fetch_fw name (M. Wajdeczko)
> v3: yet another rename - intel_uc_init_fw (J. Lahtinen)
>
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
> Cc: Michal Wajdeczko <michal.wajdeczko at intel.com>
> Cc: Michal Winiarski <michal.winiarski at intel.com>
> Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler at intel.com>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
More information about the Intel-gfx
mailing list