[Intel-gfx] [PATCH 3/3] drm/i915/perf: rate limit spurious oa report notice

[Chris Wilson]

On Tue, Feb 28, 2017 at 01:28:13PM +0000, Matthew Auld wrote:
> On 22 February 2017 at 15:25, Robert Bragg <robert at sixbynine.org> wrote:
> > This change is pre-emptively aiming to avoid a potential cause of kernel
> > logging noise in case some condition were to result in us seeing invalid
> > OA reports.
> >
> > The workaround for the OA unit's tail pointer race condition is what
> > avoids the primary know cause of invalid reports being seen and with
> > that in place we aren't expecting to see this notice but it can't be
> > entirely ruled out.
> >
> > Just in case some condition does lead to the notice then it's likely
> > that it will be triggered repeatedly while attempting to append a
> > sequence of reports and depending on the configured OA sampling
> > frequency that might be a large number of repeat notices.
> >
> > Signed-off-by: Robert Bragg <robert at sixbynine.org>
> Reviewed-by: Matthew Auld <matthew.auld at intel.com>

printk_ratelimits emits a WARN when triggered, defeating the purpose of
using NOTE.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre