[Intel-gfx] [PATCH 3/5] drm/i915: Set an error status for a resubmitted request

Tvrtko Ursulin tvrtko.ursulin at linux.intel.com
Tue Jan 10 12:13:05 UTC 2017


On 10/01/2017 10:27, Chris Wilson wrote:
> Let userspace know if its request was resubmitted due to it being
> executed at the time of a global reset. In this case, the reset was for
> a guilty request on another engine, and this request was an innocent
> victim that will be re-executed upon restarting. However, since it was
> running at the time of the reset, we can not guarantee that it suffered
> no ill-effects from the reset (e.g. some context state may be lost, or
> some self-modifying fragment shaders will be restart from the final
> state not their initial state), to let userspace know that it has been
> corrupted set a special value on the fence->error, -EAGAIN.
>
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> Cc: Mika Kuoppala <mika.kuoppala at linux.intel.com>
> ---
>  drivers/gpu/drm/i915/i915_gem.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
> index 324a49813668..94ad9eb83a5c 100644
> --- a/drivers/gpu/drm/i915/i915_gem.c
> +++ b/drivers/gpu/drm/i915/i915_gem.c
> @@ -2665,6 +2665,7 @@ static void i915_gem_reset_engine(struct intel_engine_cs *engine)
>  		reset_request(request);
>  	} else {
>  		i915_gem_context_mark_innocent(hung_ctx);
> +		dma_fence_set_error(&request->fence, -EAGAIN);
>  		return;
>  	}
>
>

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>

Regards,

Tvrtko


More information about the Intel-gfx mailing list