[Intel-gfx] [PATCH v2] drm/i915: Expand ggtt_view paramters for debugfs

[Chris Wilson]

On Thu, Jan 12, 2017 at 11:14:55AM +0000, Tvrtko Ursulin wrote:
> 
> On 12/01/2017 11:06, Chris Wilson wrote:
> >When dumping the VMA, include the parameters of the different GGTT views
> >so that we can distinguish them.
> >
> >v2: Contract output and add MISSING_CASE for any unknown types.
> >
> >Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> >Cc: Tvrtko Ursulin <tvrtko.ursulin at linux.intel.com>
> >---
> > drivers/gpu/drm/i915/i915_debugfs.c | 28 ++++++++++++++++++++++++++--
> > 1 file changed, 26 insertions(+), 2 deletions(-)
> >
> >diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> >index 9d7b5a8c8dea..72bec5eb2f18 100644
> >--- a/drivers/gpu/drm/i915/i915_debugfs.c
> >+++ b/drivers/gpu/drm/i915/i915_debugfs.c
> >@@ -159,8 +159,32 @@ describe_obj(struct seq_file *m, struct drm_i915_gem_object *obj)
> > 		seq_printf(m, " (%sgtt offset: %08llx, size: %08llx",
> > 			   i915_vma_is_ggtt(vma) ? "g" : "pp",
> > 			   vma->node.start, vma->node.size);
> >-		if (i915_vma_is_ggtt(vma))
> >-			seq_printf(m, ", type: %u", vma->ggtt_view.type);
> >+		if (i915_vma_is_ggtt(vma)) {
> >+			switch (vma->ggtt_view.type) {
> >+			case I915_GGTT_VIEW_NORMAL:
> >+				seq_puts(m, ", normal");
> >+				break;
> >+
> >+			case I915_GGTT_VIEW_PARTIAL:
> >+				seq_printf(m, ", partial [%08llx+%x]",
> >+					   vma->ggtt_view.params.partial.offset,
> >+					   vma->ggtt_view.params.partial.size << PAGE_SHIFT);
> >+				break;
> >+
> >+			case I915_GGTT_VIEW_ROTATED:
> >+				seq_printf(m, ", rotated [(%ux%u, %d), (%ux%u, %d)]",
> 
> It's all %u AFAICS. Also there is offset which I missed previously.
> If you add it we probably need to name the stride and offset fields
> then? Like (%ux%u, stride=%u, offset=%u)?

I honestly don't know how I missed the %d. And I forgot entirely about
the offset.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre