[Intel-gfx] [PATCH i-g-t] tests/kms_plane_multiple: Change number of iterations

[Kahola, Mika]

> -----Original Message-----
> From: Chris Wilson [mailto:chris at chris-wilson.co.uk]
> Sent: Thursday, January 12, 2017 2:00 PM
> To: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
> Cc: Kahola, Mika <mika.kahola at intel.com>; intel-gfx at lists.freedesktop.org
> Subject: Re: [Intel-gfx] [PATCH i-g-t] tests/kms_plane_multiple: Change number
> of iterations
> 
> On Thu, Jan 12, 2017 at 12:53:30PM +0100, Maarten Lankhorst wrote:
> > Op 12-01-17 om 12:12 schreef Mika Kahola:
> > > In CI system, the default 64 iterations of this test may cause CRC
> > > overflow warnings in dmesg when debugfs is enabled in kernel config.
> > > To keep dmesg warning noise in minimum, let's run this test only once by
> default.
> > >
> > > Signed-off-by: Mika Kahola <mika.kahola at intel.com>
> > > ---
> > >  tests/kms_plane_multiple.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/tests/kms_plane_multiple.c b/tests/kms_plane_multiple.c
> > > index 5e12be4..b94ec36 100644
> > > --- a/tests/kms_plane_multiple.c
> > > +++ b/tests/kms_plane_multiple.c
> > > @@ -62,7 +62,7 @@ struct {
> > >  	bool user_seed;
> > >  	int seed;
> > >  } opt = {
> > > -	.iterations = 64,
> > > +	.iterations = 1,
> > >  	.user_seed = false,
> > >  	.seed = 1,
> > >  };
> >
> > Reviewed-by: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
> >
> > Though such small changes don't need review. :)
> 
> I am also intrigued as to what a "CRC overflow warning" is and why userspace
> needs to take remedial action to hide the warning.
>From CI runs you may see these errors

[drm:display_pipe_crc_irq_handler [i915]] *ERROR* CRC buffer overflowing

For a real fix, should we increase the size of ringbuffer where crc's are stored or in the kms_plane_multiple test wait for a while before running the next iteration?

> -Chris
> 
> --
> Chris Wilson, Intel Open Source Technology Centre