[Intel-gfx] [PATCH v2] drm/i915: Declare i915_gem_object_create_internal() as taking phys_addr_t size
Joonas Lahtinen
joonas.lahtinen at linux.intel.com
Thu Jan 12 13:39:09 UTC 2017
On to, 2017-01-12 at 13:04 +0000, Chris Wilson wrote:
> The internal object is a collection of struct pages and so is
> intrinsically linked to the available physical memory on the machine,
> and not an arbitrary type from the uabi. Use phys_addr_t so the link
> between size and memory consumption is clear, and then double check that
> we don't overflow the maximum object size.
>
> v2: Also assert that size is not zero - a mistake I made a few times
> while writing selftests.
>
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
More information about the Intel-gfx
mailing list