[Intel-gfx] [PATCH v2 4/7] drm/i915: Stop clearing i915_ggtt_view

[Tvrtko Ursulin]

On 12/01/2017 21:35, Chris Wilson wrote:
> As we now use a compact memcmp in i915_vma_compare(), we can forgo
> clearing the entire view and only set the precise parameters used in
> this view.
>
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> ---
>  drivers/gpu/drm/i915/i915_gem.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
> index 3bf517e2430a..f034d8d2dd4c 100644
> --- a/drivers/gpu/drm/i915/i915_gem.c
> +++ b/drivers/gpu/drm/i915/i915_gem.c
> @@ -1759,7 +1759,6 @@ compute_partial_view(struct drm_i915_gem_object *obj,
>  	if (i915_gem_object_is_tiled(obj))
>  		chunk = roundup(chunk, tile_row_pages(obj));
>
> -	memset(&view, 0, sizeof(view));
>  	view.type = I915_GGTT_VIEW_PARTIAL;
>  	view.params.partial.offset = rounddown(page_offset, chunk);
>  	view.params.partial.size =
>

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>

Regards,

Tvrtko