[Intel-gfx] [PATCH] dim: Triple-check and tripe warning when merging patches that touch files outside i915.

[Rodrigo Vivi]

On Thu, Jan 12, 2017 at 11:04 PM, Jani Nikula <jani.nikula at intel.com> wrote:
> On Fri, 13 Jan 2017, Rodrigo Vivi <rodrigo.vivi at intel.com> wrote:
>> Most of commiters already knows that by heart and also dim already
>> have this warning. So maybe this is just Bart writing to blackboard. Duh!
>>
>> Anyway for my own usage this tripe check will help for sure.
>> Maybe it help someone else in the future.
>
> Well, this has changed with drm-misc; very few of the commits there have
> acks from Dave. And that was sort of the point in that tree, to scale
> better and not depend on his acks on every little detail.

Ah cool!

>
> I suppose the checks in dim could be branch specific.

makes sense. but what is beter for this new check?
1. if is drm-intel-next-queued
2 if not drm-misc

any modification on the current warning?

Thanks,
Rodrigo.

>
> BR,
> Jani.
>
>
>>
>> Cc: Daniel Vetter <daniel.vetter at ffwll.ch>
>> Cc: Jani Nikula <jani.nikula at intel.com>
>> Signed-off-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
>> ---
>>  dim           | 4 ++++
>>  drm-intel.rst | 4 +++-
>>  2 files changed, 7 insertions(+), 1 deletion(-)
>>
>> diff --git a/dim b/dim
>> index eec5e43..73f6212 100755
>> --- a/dim
>> +++ b/dim
>> @@ -933,6 +933,10 @@ function checkpatch_commit
>>                       echo -e "The following files are outside of i915 maintenance scope:\n"
>>                       echo "$non_i915_files"
>>                       echo -e "\nConfirm you have appropriate Acked-by and Reviewed-by for above files."
>> +                     local acked_by_airlie=$($cmd | grep "Acked-by: Dave Airlie <airlied at redhat.com>")
>> +                     if [ "$acked_by_airlie" == "" ]; then
>> +                         echo -e "\nRemind that for drm you should have an Acked-by from Dave Airlie <airlied at redhat.com>"
>> +                     fi
>>               fi
>>       fi
>>  }
>> diff --git a/drm-intel.rst b/drm-intel.rst
>> index 79db1cf..583a687 100644
>> --- a/drm-intel.rst
>> +++ b/drm-intel.rst
>> @@ -300,7 +300,9 @@ the right decisions, and for others to set their the expectations right.
>>
>>  The short list:
>>
>> -* Only push patches changing `drivers/gpu/drm/i915`.
>> +* Only push patches changing `drivers/gpu/drm/i915`. If dim mentioned that you
>> +  are touching files outside i915 stop and make sure that you have the proper
>> +  Acked-by. Specially for drm files an Acked-by from Dave Airlie is required.
>>
>>  * Only push patches to `drm-intel-next-queued` branch.
>
> --
> Jani Nikula, Intel Open Source Technology Center
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx



-- 
Rodrigo Vivi
Blog: http://blog.vivi.eng.br