[Intel-gfx] [PATCH 7/8] drm/i915/huc: Support HuC authentication

[Chris Wilson]

On Fri, Jan 13, 2017 at 06:19:53PM +0000, Srivatsa, Anusha wrote:
> >> +	/* Invalidate GuC TLB to let GuC take the latest updates to GTT. */
> >> +	I915_WRITE(GEN8_GTCR, GEN8_GTCR_INVALIDATE);

This is not required on drm-tip.

> >> +	/* Specify auth action and where public signature is. */
> >> +	data[0] = INTEL_GUC_ACTION_AUTHENTICATE_HUC;
> >> +	data[1] = i915_ggtt_offset(vma) + huc->fw.rsa_offset;
> >> +
> >> +	ret = intel_guc_send(guc, data, ARRAY_SIZE(data));
> >> +	if (ret) {
> >> +		DRM_ERROR("HuC: GuC did not ack Auth request %d\n", ret);
> >> +		goto out;
> >> +	}
> >> +
> >> +	/* Check authentication status, it should be done by now */
> >> +	ret = intel_wait_for_register(dev_priv,
> >> +				HUC_STATUS2,
> >> +				HUC_FW_VERIFIED,
> >> +				HUC_FW_VERIFIED,
> >> +				50);
> >> +
> >> +	if (ret) {
> >> +		DRM_ERROR("HuC: Authentication failed %d\n", ret);
> >> +		goto out;
> >> +	}
> >> +
> >> +	DRM_INFO("HuC Authentication Successful!\n");

You still seem surprised. Is this a useful user message? What does it
mean for the user? Avoid using jargon when talking to the user.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre