[Intel-gfx] [PATCH] drm: Fix for invalid pruning of modes in dual display cases
vidya.srinivas at intel.com
Mon Jan 16 10:13:03 UTC 2017
> -----Original Message-----
> From: Ville Syrjälä [mailto:ville.syrjala at linux.intel.com]
> Sent: Tuesday, December 13, 2016 9:17 PM
> To: Jani Nikula <jani.nikula at linux.intel.com>
> Cc: Chris Wilson <chris at chris-wilson.co.uk>; Srinivas, Vidya
> <vidya.srinivas at intel.com>; intel-gfx at lists.freedesktop.org; Syrjala, Ville
> <ville.syrjala at intel.com>; dri-devel at lists.freedesktop.org
> Subject: Re: [Intel-gfx] [PATCH] drm: Fix for invalid pruning of modes in dual
> display cases
> On Tue, Dec 13, 2016 at 04:52:01PM +0200, Jani Nikula wrote:
> > On Tue, 13 Dec 2016, Chris Wilson <chris at chris-wilson.co.uk> wrote:
> > > On Tue, Dec 13, 2016 at 03:46:54PM +0530, Vidya Srinivas wrote:
> > >> Currently in dual display connected boot scenarios, minimum of the
> > >> resolutions is taken for fb width and height as reference. Based on
> > >> this resolution, other modes are pruned.
> > >>
> > >> Example Scenario: If DSI mode is 2560x1440 and HDMI is 1920x1080,
> > >> during the probing the fb width and height is set to max 1920x1080
> > >> and the DSI mode gets pruned as it is more than the reference. As a
> result, there is no DSI display.
> > >> Patch fixes this issue by taking the max of the resolutions and
> > >> creating the fb based on the same.
> > >
> > > On the other hand, the viewable content is defined by the smaller mode.
> > > If that is the only output visible at panic time, you don't want
> > > that information lost due to it being invisible.
> > >
> > > This is only used for fbcon, which has to be the lowest common
> > > denominator. Any actual application can set their own modes and fb.
> > Do we fail to take over non-native modes with scaling on DSI then?
> > Ville?
> I believe we are taking the panel fitter into account when we reconstruct the
> BIOS fb. So in case the BIOS is upscaling we'll come up with some less than
> screen size framebuffer. The fb helper will want to use the native mode of
> the panel however, so at some point we'll drop the BIOS fb (as it's too small)
> and allocate a new one.
We are not sure how to take this further. Can you please provide some inputs
for next steps on this? We will try to make the changes and test as per your
> Ville Syrjälä
> Intel OTC
More information about the Intel-gfx