[Intel-gfx] [PATCH] drm/i915: Avoid drm_atomic_state_put(NULL) on error paths

Chris Wilson chris at chris-wilson.co.uk
Wed Jan 18 13:58:15 UTC 2017


On Wed, Jan 18, 2017 at 12:49:00PM +0000, Chris Wilson wrote:
> On Wed, Jan 18, 2017 at 02:34:28PM +0200, Ander Conselvan de Oliveira wrote:
> > The error paths in hsw_trans_edp_pipe_A_crc_wa() and
> > intel_prepare_reset() would potentially call drm_atomic_state_put with a
> > NULL state, which would lead to a NULL pointer dereference.
> > 
> > Found by coverity.
> > 
> > v2: Improve the error paths. (Chris)
> > 
> > Fixes: 0853695c3ba4 ("drm: Add reference counting to drm_atomic_state")
> > Cc: Chris Wilson <chris at chris-wilson.co.uk>
> > Cc: Daniel Vetter <daniel.vetter at ffwll.ch>
> > Cc: <drm-intel-fixes at lists.freedesktop.org> # v4.10-rc1+
> > Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira at intel.com>
> Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>

Thanks for the patch for yet another of my mistakes.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list