[Intel-gfx] [PATCH 2/2] drm/i915: Fix W=1 warning for csr_load_work_fn()

Mika Kuoppala mika.kuoppala at linux.intel.com
Wed Jan 18 14:24:48 UTC 2017


Chris Wilson <chris at chris-wilson.co.uk> writes:

> drivers/gpu/drm/i915/intel_csr.c: In function ‘csr_load_work_fn’:
> drivers/gpu/drm/i915/intel_csr.c:399:6: error: variable ‘ret’ set but not used [-Werror=unused-but-set-variable]
>
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>

Reviewed-by: Mika Kuoppala <mika.kuoppala at intel.com>

> ---
>  drivers/gpu/drm/i915/intel_csr.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c
> index 0085bc745f6a..9dcc434d3b74 100644
> --- a/drivers/gpu/drm/i915/intel_csr.c
> +++ b/drivers/gpu/drm/i915/intel_csr.c
> @@ -396,13 +396,11 @@ static void csr_load_work_fn(struct work_struct *work)
>  	struct drm_i915_private *dev_priv;
>  	struct intel_csr *csr;
>  	const struct firmware *fw = NULL;
> -	int ret;
>  
>  	dev_priv = container_of(work, typeof(*dev_priv), csr.work);
>  	csr = &dev_priv->csr;
>  
> -	ret = request_firmware(&fw, dev_priv->csr.fw_path,
> -			       &dev_priv->drm.pdev->dev);
> +	request_firmware(&fw, dev_priv->csr.fw_path, &dev_priv->drm.pdev->dev);
>  	if (fw)
>  		dev_priv->csr.dmc_payload = parse_csr_fw(dev_priv, fw);
>  
> -- 
> 2.11.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx


More information about the Intel-gfx mailing list