[Intel-gfx] [PATCH i-g-t v1 5/6] tests/kms_cursor_legacy: Switch to using for_each_pipe construct
chris at chris-wilson.co.uk
Thu Jan 19 19:01:38 UTC 2017
On Thu, Jan 19, 2017 at 12:35:48PM -0500, Robert Foss wrote:
> On 2017-01-19 12:17 PM, Chris Wilson wrote:
> >On Thu, Jan 19, 2017 at 11:35:05AM -0500, Robert Foss wrote:
> >>Avoid using hand-rolled construct for iterating over all pipes.
> >display->n_pipes is a variable and depends upon the drmModeGetResources().
> >It not only changes between machines, but we don't probe the resources
> >when listing tests. Both lead to variable sets of tests.
> Primarily I was intending to avoid the igt_skip_on()_on by using a
> commonly used structures that Should Just Work, for_each_pipe().
> Does that make sense?
Sure it makes sense. It just doesn't work right now.
Chris Wilson, Intel Open Source Technology Centre
More information about the Intel-gfx