[Intel-gfx] [PATCH v2] pwm: lpss: Make builtin so that i915 can find the pwm_backlight

Hans de Goede hdegoede at redhat.com
Fri Jan 20 10:18:29 UTC 2017


On 20-01-17 10:55, Andy Shevchenko wrote:
> On Fri, 2017-01-20 at 10:48 +0100, Hans de Goede wrote:
>> I'm fine with doing a v3 with a comment, how about putting that
>> comment
>> right at all the module* stuff and explain there that that is to
>> stay as the builtin only status is meant to be temporary ?
> Can we do other way around? I mean that either i915 selects PWM_LPSS to
> be built-in, or uses request_module() call?

PWM_LPSS needs to be built-in if enabled, a stripped down kernel
for non cherrytrail hardware does not need it ...

Also (and esp for request_module) this means building knowledge
into the i915 driver about which pwm hardware there is on which
boards which is undesirable.

Thierry, this does give me an idea though, what if we extend
the info passed to pwm_add_table with a module-name and
make pwm_get call request_module() ?

That seems like a good solution and we could then also make
PWM_CRC a tristate again (after someone with hw access has tested



More information about the Intel-gfx mailing list