[Intel-gfx] [PATCH v4 4/5] ALSA: x86: hdmi: Add audio support for BYT and CHT

Takashi Iwai tiwai at suse.de
Fri Jan 20 11:15:24 UTC 2017

On Fri, 20 Jan 2017 23:22:31 +0100,
Jerome Anand wrote:
> +	had_ops_v1 = had_ops_v1;	/* unused */

Until now I didn't realize that the whole v1 stuff is never used in
the current patchset.  Will it be ever used in future?  If not, can't
we clean it up?  It's a bunch of codes, including the messy union
definitions.  If there is no v3 or whatever, we can even get rid of
the whole indirect calls.

And if v1 (and the indirect ops calls) should be kept, actually what
is the difference between v1 and v2, why both implementations do
exist?  Please elaborate in comments.



More information about the Intel-gfx mailing list