[Intel-gfx] [PATCH 1/2] drm/i915: Assert the vma can fit within the address space

Joonas Lahtinen joonas.lahtinen at linux.intel.com
Fri Jan 20 11:35:59 UTC 2017


On to, 2017-01-19 at 14:30 +0000, Chris Wilson wrote:
> On Thu, Jan 19, 2017 at 12:58:46PM +0000, Chris Wilson wrote:
> > 
> > Useful sanity check that the vma is legal to bind inside the address
> > space.
> > 
> > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>

<SNIP>

> > +	GEM_BUG_ON(vma->size > vm->total);
> 
> Seconds thoughts, it is probably wiser to bail here with
> ERR_PTR(-E2BIG); We don't check in execbuf and this stops from having to
> write patch 2 as well.

I had similar thoughts, so slap my R-b for that (with same condition).

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation


More information about the Intel-gfx mailing list