[Intel-gfx] [PATCH 2/6] drm/i915: Use common LRU inactive vma bumping for unpin_from_display

Joonas Lahtinen joonas.lahtinen at linux.intel.com
Fri Jan 20 12:32:32 UTC 2017


On to, 2017-01-19 at 19:26 +0000, Chris Wilson wrote:
> Now that i915_gem_object_bump_inactive_ggtt() exists, also make use of
> it for the LRU bumping from i915_gem_object_unpin_from_display()
> 
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>

<SNIP>

>  	/* Bump the LRU to try and avoid premature eviction whilst flipping  */
> -	if (!i915_vma_is_active(vma))
> -		list_move_tail(&vma->vm_link, &vma->vm->inactive_list);
> +	i915_gem_object_bump_inactive_ggtt(vma->obj);

Infrequently called function, so the loop within doesn't hurt;

Reviewed-by: Jonas Lahtinen <joonas.lahtinen at linux.intel.com>

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation


More information about the Intel-gfx mailing list