[Intel-gfx] [PATCH 1/6] drm/i915: Pass around gen to tile_height to special case gen2

Joonas Lahtinen joonas.lahtinen at linux.intel.com
Fri Jan 20 12:37:44 UTC 2017

On pe, 2017-01-20 at 10:36 +0000, Chris Wilson wrote:
> On Thu, Jan 19, 2017 at 09:44:23PM +0200, Ville Syrjälä wrote:
> > 
> > Still inaccurate for 915+Y, but if this is only used to compute the tile
> > row size it'll just give a needlessly large answer and so should be
> > safe.
> The alternative is that this code is only relevant for gen4+. I wonder
> if renaming and restricting at the caller is more tidy.

I think caller restriction would be better, addresses my concern about
the gen parameter too.

Regards, Joonas
Joonas Lahtinen
Open Source Technology Center
Intel Corporation

More information about the Intel-gfx mailing list