[Intel-gfx] [PATCH] drm/i915: reinstate call to trace_i915_vma_bind

[Chris Wilson]

On Fri, Jan 20, 2017 at 01:16:13PM -0800, Daniele Ceraolo Spurio wrote:
> Ping. can anyone review/comment on this?
> 
> Thanks,
> Daniele
> 
> On 12/01/17 14:21, daniele.ceraolospurio at intel.com wrote:
> >From: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
> >
> >The call went away in:
> >
> >commit 3b16525cc4c1a43e9053cfdc414356eea24bdfad
> >Author: Chris Wilson <chris at chris-wilson.co.uk>
> >Date:   Thu Aug 4 16:32:25 2016 +0100
> >
> >    drm/i915: Split insertion/binding of an object into the VM
> >
> >It is useful to have this trace as it pairs nicely with the vma_unbind
> >one to track vma activity.
> >Added inside the i915_vma_bind function (was outside before) to keep a
> >similar placement as trace_i915_vma_unbind.
> >
> >Cc: Chris Wilson <chris at chris-wilson.co.uk>
> >Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
> >---
> > drivers/gpu/drm/i915/i915_vma.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> >diff --git a/drivers/gpu/drm/i915/i915_vma.c b/drivers/gpu/drm/i915/i915_vma.c
> >index b74eeb7..b593748 100644
> >--- a/drivers/gpu/drm/i915/i915_vma.c
> >+++ b/drivers/gpu/drm/i915/i915_vma.c
> >@@ -207,6 +207,7 @@ int i915_vma_bind(struct i915_vma *vma, enum i915_cache_level cache_level,
> > 			return ret;
> > 	}
> >
> >+	trace_i915_vma_bind(vma, flags);

We need it but that's not the information being used in the bind.
(I know that's what it used to be, but it's a long time since it was
correct.)

> > 	ret = vma->vm->bind_vma(vma, cache_level, bind_flags);
> > 	if (ret)
> > 		return ret;
> >
> 

-- 
Chris Wilson, Intel Open Source Technology Centre