[Intel-gfx] [PATCH 2/2] drm/i915: Assert that the context-switch completion matches our context

Joonas Lahtinen joonas.lahtinen at linux.intel.com
Mon Jan 23 08:26:00 UTC 2017


On la, 2017-01-21 at 17:29 +0000, Chris Wilson wrote:
> When execlists signals the context completion, it also provides the
> context id for the status event. Assert that id matches the one we expect.
> 
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>

<SNIP>

> @@ -595,6 +595,10 @@ static void intel_lrc_irq_handler(unsigned long data)
>  			if (!(status & GEN8_CTX_STATUS_COMPLETED_MASK))
>  				continue;
>  
> +			/* Check the context id for this event matches */
> +			GEM_BUG_ON(readl(buf + 2 * idx + 1) !=
> +				   port[0].request->ctx->hw_id);
> +
>  			GEM_BUG_ON(port[0].count == 0);
>  			if (--port[0].count == 0) {
>  				GEM_BUG_ON(status & GEN8_CTX_STATUS_PREEMPTED);

This is good for now, Mika has to update it for the SVM code, though.

(Counterpart at intel_lr_context_descriptor_update).

Reviewed-by: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation


More information about the Intel-gfx mailing list