[Intel-gfx] [PATCH v2 1/5] drm/i915: Only disable execlist preemption for the duration of the request

[Mika Kuoppala]

Chris Wilson <chris at chris-wilson.co.uk> writes:

> On Mon, Jan 23, 2017 at 12:14:25PM +0000, Chris Wilson wrote:
>> @@ -558,7 +558,8 @@ static bool execlists_elsp_ready(struct intel_engine_cs *engine)
>>  	int port;
>>  
>>  	port = 1; /* wait for a free slot */
>> -	if (engine->disable_lite_restore_wa || engine->preempt_wa)
>> +	if (engine->disable_lite_restore_wa ||
>> +	    engine->execlist_port[0].count > 1)
>>  		port = 0; /* wait for GPU to be idle before continuing */
>
> The disable_lite_restore_wa is a preproduction wa, right? Do we still
> want to keep it?
>

I was about to suggest to getting rid of it. I remeber doing it
but patches are lost somewhere.

The concern with the preempt_wa change is that does it work? =)

-Mika

> If not this could be rewritten as
>
> return port[0].count + port[1].count < 2;
> -Chris
>
> -- 
> Chris Wilson, Intel Open Source Technology Centre
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx