[Intel-gfx] [CI 6/7] drm/i915: Eliminate superfluous i915_ggtt_view_rotated

Matthew Auld matthew.william.auld at gmail.com
Mon Jan 23 13:51:54 UTC 2017


On 14 January 2017 at 00:28, Chris Wilson <chris at chris-wilson.co.uk> wrote:
> It is only being used to clear a struct and set the type, after which it
> is overwritten. Since we no longer check the unset bits of the union,
> skipping the clear is permissible.
>
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> Reviewed-by: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
My machine is all of a sudden hanging just after boot and bisection
points to this as the culprit. When I revert back to the old behaviour
of copying from the zeroed struct for the normal case, then the issue
disappears, which doesn't make any sense. Any ideas?


More information about the Intel-gfx mailing list