[Intel-gfx] [PATCH] drm/i915: Use atomic page flip for intel again.
maarten.lankhorst at linux.intel.com
Mon Jan 23 15:02:18 UTC 2017
Op 27-12-16 om 15:48 schreef Daniel Vetter:
> On Thu, Dec 22, 2016 at 11:33:23AM +0100, Maarten Lankhorst wrote:
>> This reverts commit 527b6abe5fd2d2
>> (Revert "drm/i915: Use atomic commits for legacy page_flips")
>> and reapplies commit ee042aa40b66d1.
>> ("drm/i915: Use atomic commits for legacy page_flips")
>> The reason for the revert was because legacy cursor updates were
>> forced to wait for pending page flips and rendering after they
>> were converted to atomic.
>> Commit f79f26921ee12c6f
>> (drm/i915: Add a cursor hack to allow converting legacy page flip to atomic, v3)
>> adds a fastpath to cursor updates, which fixes the stuttering issues.
>> With these changes I feel confident enough to re-enable cursor updates.
>> Legacy cursor update won't block in the following cases:
>> - Moving cursor
>> - Changing cursor fb
>> The legacy cursor update will still block in the following cases:
>> - Showing/hiding cursor.
>> - Cursor size or scaling changes.
>> - cursor update while cursor is invisible (could be fixed, if it turns out to be important).
>> - Cursor tiling changes (Not sure we support tiled cursors.)
>> - Last update was a modeset.
>> Cc: Steven Newbury <steve at snewbury.org.uk>
>> Cc: Rafael Ristovski <rafael.ristovski at gmail.com>
>> Cc: Chris Wilson <chris at chris-wilson.co.uk>
>> Cc: Daniel Vetter <daniel.vetter at ffwll.ch>
>> Tested-by: Rafael Ristovski <rafael.ristovski at gmail.com>
>> Testcase: igt/kms_cursor_legacy
>> Signed-off-by: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
> I'm going to regret this again ;-)
> Reviewed-by: Daniel Vetter <daniel.vetter at ffwll.ch>
But we have testcases now! That pass!! So pushed, thanks for review. ;)
More information about the Intel-gfx