[Intel-gfx] [PATCH 1/4] drm/i915: Disable plane gamma in SKL+ sprite planes

[Ville Syrjälä]

On Tue, Jan 24, 2017 at 03:35:52PM +0200, Ander Conselvan de Oliveira wrote:
> The plane gamma tables are never programmed, so just disable it, like it
> is done for the primary plane.
> 
> Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira at intel.com>
> ---
>  drivers/gpu/drm/i915/intel_sprite.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/i915/intel_sprite.c b/drivers/gpu/drm/i915/intel_sprite.c
> index 9ef5468..c05545f 100644
> --- a/drivers/gpu/drm/i915/intel_sprite.c
> +++ b/drivers/gpu/drm/i915/intel_sprite.c
> @@ -226,6 +226,7 @@ skl_update_plane(struct drm_plane *drm_plane,
>  	plane_ctl |= skl_plane_ctl_format(fb->format->format);
>  	plane_ctl |= skl_plane_ctl_tiling(fb->modifier);
>  
> +	plane_ctl |= PLANE_CTL_PLANE_GAMMA_DISABLE;

Reviewed-by: Ville Syrjälä <ville.syrjala at linux.intel.com>

Though what I'd like to see is someone eliminating this primary vs.
sprite code duplication entirely. I think (or at lest hope) that it
should be trivial since I added the plane_id thing.

>  	plane_ctl |= skl_plane_ctl_rotation(rotation);
>  
>  	if (key->flags) {
> -- 
> 2.5.5
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel OTC