[Intel-gfx] [PATCH 1/3] drm/i915: Make intel_detect_preproduction_hw easier to extend

[Chris Wilson]

On Thu, Jan 26, 2017 at 01:16:03PM +0000, Chris Wilson wrote:
> On Thu, Jan 26, 2017 at 03:02:14PM +0200, Ville Syrjälä wrote:
> > On Thu, Jan 26, 2017 at 12:50:28PM +0000, Chris Wilson wrote:
> > > As we add new generations, we should keep detecting new system
> > > development platforms that were temporarily enabled (via
> > > "i915.alpha_support") and now superseded by production systems. To make
> > > it easier to add more platforms, split the if into a series of logical
> > > operations.
> > > 
> > > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> > > Cc: "Zanoni, Paulo R" <paulo.r.zanoni at intel.com>
> > > Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
> > > Cc: Jani Nikula <jani.nikula at intel.com>
> > > Cc: Ville Syrjälä <ville.syrjala at linux.intel.com>
> > > ---
> > >  drivers/gpu/drm/i915/i915_drv.c | 8 ++++++--
> > >  1 file changed, 6 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> > > index 008fc1e62a69..c2c210b0f47f 100644
> > > --- a/drivers/gpu/drm/i915/i915_drv.c
> > > +++ b/drivers/gpu/drm/i915/i915_drv.c
> > > @@ -782,8 +782,12 @@ static void i915_workqueues_cleanup(struct drm_i915_private *dev_priv)
> > >   */
> > >  static void intel_detect_preproduction_hw(struct drm_i915_private *dev_priv)
> > >  {
> > > -	if (IS_HSW_EARLY_SDV(dev_priv) ||
> > > -	    IS_SKL_REVID(dev_priv, 0, SKL_REVID_F0))
> > > +	bool sdv = false;
> > 
> > Presumably not all SDVs use pre-production silicon, so the name of
> > this variable feels a bit off. Also since it doesn't actually check
> > anything about the actual board we can't even say that it's an
> > actual SDV, so the HSW_EARLY_SDV() macro seems somewhat poorly named
> > to me as well.
> 
> I started with bool preproduction; but that eats too many characters.
> Ideas for something short and snappy? bool alpha_hw? bool alpha?

Preferring bool pre; to avoid the connotations of "alpha hardware". All
our hardware is perfect.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre