[Intel-gfx] [PATCH i-g-t] lib/drmtest: make DRIVER_ANY match any driver

Robert Foss robert.foss at collabora.com
Fri Jan 27 22:54:29 UTC 2017


Thanks Eric,

This does looks like a reasonable change to me.
I don't think there are any legacy reasons for excluding VGEM from 
testing in DRIVER_ANY compatible tests.

On 2017-01-24 10:27 AM, Eric Engestrom wrote:
> Signed-off-by: Eric Engestrom <eric.engestrom at imgtec.com>
> ---
> Not tested or anything, I just happened to notice this code and it
> looked wrong, but maybe I misunderstood what it was meant to do.
>
> An alternative would be to just set the bits the the drivers that are
> defined already, but that would require an update everytime a new
> DRIVER_* is added (error-prone):
> 	#define DRIVER_ANY	((1 << 4) - 1)
> ---
>  lib/drmtest.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/drmtest.h b/lib/drmtest.h
> index 19d4bd19..1d41df93 100644
> --- a/lib/drmtest.h
> +++ b/lib/drmtest.h
> @@ -42,7 +42,7 @@
>  #define DRIVER_VC4	(1 << 1)
>  #define DRIVER_VGEM	(1 << 2)
>  #define DRIVER_VIRTIO	(1 << 3)
> -#define DRIVER_ANY 	~(DRIVER_VGEM)
> +#define DRIVER_ANY	(~0)
>
>  #ifdef ANDROID
>  #if (!(defined HAVE_MMAP64)) && (!(defined __x86_64__))
>


More information about the Intel-gfx mailing list