[Intel-gfx] [PATCH v2 3/3] acpi: lpss: call pwm_add_table() for bsw PWM device

Mika Westerberg mika.westerberg at linux.intel.com
Mon Jan 30 09:33:10 UTC 2017


On Mon, Jan 30, 2017 at 09:28:09AM +0100, Rafael J. Wysocki wrote:
> On Mon, Jan 30, 2017 at 9:18 AM, Thierry Reding
> <thierry.reding at gmail.com> wrote:
> > On Sun, Jan 22, 2017 at 05:14:09PM +0100, Hans de Goede wrote:
> >> On x86 we do not have devicetree to link the PWM controller and
> >> the display controller together. So someone needs to call
> >> pwm_add_table() to create the link, so that the i915 driver's
> >> pwm_get(dev, "pwm_backlight") call returns the lpss' pwm0.
> >>
> >> The PWM subsystem does not want to have pwm_add_table() calls
> >> directly in PWM drivers (this leads to probe ordering issues),
> >> so lets do it here since the acpi-lpss code is always builtin.
> >>
> >> Signed-off-by: Hans de Goede <hdegoede at redhat.com>
> >> Acked-by: Thierry Reding <thierry.reding at gmail.com>
> >> ---
> >> Changes in v2:
> >> -Set new pwm_lookup module_name field in the table
> >> ---
> >>  drivers/acpi/acpi_lpss.c | 13 +++++++++++++
> >>  1 file changed, 13 insertions(+)
> >
> > Rafael, do you mind if I take this through the PWM tree to resolve the
> > build-time dependency?
> 
> No, I don't, please go ahead, unless Mika/Andy see any problems in it.

No problems from my side - looks good.


More information about the Intel-gfx mailing list