[Intel-gfx] [PATCH v2 1/3] drm/i915: Make intel_detect_preproduction_hw easier to extend

[Chris Wilson]

On Mon, Jan 30, 2017 at 03:11:07PM +0200, Jani Nikula wrote:
> On Mon, 30 Jan 2017, Joonas Lahtinen <joonas.lahtinen at linux.intel.com> wrote:
> > On ma, 2017-01-30 at 10:44 +0000, Chris Wilson wrote:
> >> As we add new generations, we should keep detecting new pre-production
> >> system development platforms that were temporarily enabled to facilitate
> >> initial development and now superseded by production systems. To make
> >> it easier to add more platforms, split the if into a series of logical
> >> operations.
> >> 
> >> v2: s/sdv/pre/ - not all system development vehicles are for
> >> preproduction usage.
> >> 
> >> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> >> Cc: "Zanoni, Paulo R" <paulo.r.zanoni at intel.com>
> >> Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
> >> Cc: Jani Nikula <jani.nikula at intel.com>
> >> Cc: Ville Syrjälä <ville.syrjala at linux.intel.com>
> >
> > <SNIP>
> >
> >>  static void intel_detect_preproduction_hw(struct drm_i915_private *dev_priv)
> >>  {
> >> -	if (IS_HSW_EARLY_SDV(dev_priv) ||
> >> -	    IS_SKL_REVID(dev_priv, 0, SKL_REVID_F0))
> >> +	bool pre = false;
> >> +
> >> +	pre |= IS_HSW_EARLY_SDV(dev_priv);
> >> +	pre |= IS_SKL_REVID(dev_priv, 0, SKL_REVID_F0);
> >
> > Did you compare the asm with "pre = pre || ..."?
> 
> Yeah, this definitely needs to be optimized. :p

Thank goodness it makes no difference!
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre