[Intel-gfx] [PATCH i-g-t v2] tests: Validate TEST_ONLY correctness against full atomic commit

Maarten Lankhorst maarten.lankhorst at linux.intel.com
Mon Jan 30 14:16:27 UTC 2017

Op 30-01-17 om 14:22 schreef Mika Kahola:
> On Mon, 2017-01-30 at 13:43 +0100, Maarten Lankhorst wrote:
>> Op 30-01-17 om 12:37 schreef Mika Kahola:
>>> Validate atomic commit correctness before actual commit.
>>> For: VIZ-6956
>>> v2: Add flag to toggle TEST_ONLY for atomic commit.
>>>     Remove DRM_MODE_PAGE_FLIP_EVENT flag, if enabled, before trying
>>> atomic
>>>     commit with TEST_ONLY flag (Maarten)
>>> Cc: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
>>> Signed-off-by: Mika Kahola <mika.kahola at intel.com>
>>> <snip>
>> Hey,
>> Way too complicated, I thought of something like this instead too run
>> a whole test with TEST_ONLY.
> Ok, let's go with this approach. 
> To follow JIRA description for this test I was thinking to add yet
> another subtest for each kms_* that tests first with TEST_ONLY flag and
> if that fails with -EINVAL then test with the real deal.
Yeah, this is mostly meant for debugging in some existing tests. To validate
TEST_ONLY we could add a kms_atomic_test_only test, which can also be used to
see if a test with TEST_ONLY is not accidentally being committed by reading
plane/connector/crtc properties and compare before against after, which is also a JIRA.


More information about the Intel-gfx mailing list