[Intel-gfx] [PATCH 3/4] drm/i915: Drop request retirement before reaping stale contexts

[Tvrtko Ursulin]

On 05/07/2017 15:26, Chris Wilson wrote:
> Before we create a new context, we try and reap all the stale contexts
> (i.e. those that are freed but waiting for a worker to come and return
> their allocations to the system). Before we do this, we retire all
> requests so that we clear any inflight no longer used contexts (who are
> only being kept alived by those inflght requests). However, any context
> that is finally unreferenced by this retirement is put onto an RCU list
> and not available for immediately reaping, we stall for no immediate
> benefit.
> 
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> ---
>   drivers/gpu/drm/i915/i915_gem_context.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_gem_context.c b/drivers/gpu/drm/i915/i915_gem_context.c
> index c58a95c33c25..4f6773ea7d85 100644
> --- a/drivers/gpu/drm/i915/i915_gem_context.c
> +++ b/drivers/gpu/drm/i915/i915_gem_context.c
> @@ -384,7 +384,6 @@ i915_gem_create_context(struct drm_i915_private *dev_priv,
>   	lockdep_assert_held(&dev_priv->drm.struct_mutex);
>   
>   	/* Reap stale contexts */
> -	i915_gem_retire_requests(dev_priv);
>   	contexts_free(dev_priv);
>   
>   	ctx = __create_hw_context(dev_priv, file_priv);
> 

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>

Regards,

Tvrtko