[Intel-gfx] [PATCH i-g-t v2 2/2] tests/gem_reset_stats: Enforce full chip reset mode before run

Michel Thierry michel.thierry at intel.com
Fri Jul 7 00:54:27 UTC 2017


On 06/07/17 15:50, Antonio Argenziano wrote:
>> +
>> +    igt_fixture {
>> +        int fd;
>> +
>> +        fd = drm_open_driver(DRIVER_INTEL);
>> +        igt_assert(igt_sysfs_set_parameter
>> +               (fd, "reset", "%d", INT_MAX /* any reset method */));
> 
> I would still suggest that we restore the reset value we had at the 
> beginning of the test. I think that since we disabled single engine, 
> this would actually set the parameter to an unsafe value.

I talked with Antonio offline about it, but long story short, it doesn't 
matter much.

Writing INT_MAX to i915.reset is safe; a platform without reset-engine 
support will still only do (and most important, report via the get-param 
ioctl) that it can only do full-gpu-reset, even though i915.reset > 1.

-Michel


More information about the Intel-gfx mailing list