[Intel-gfx] [PATCH] drm/i915: Fix the kernel panic when using aliasing ppgtt
Dong, Chuanxiao
chuanxiao.dong at intel.com
Fri Jul 7 09:49:56 UTC 2017
> -----Original Message-----
> From: Chris Wilson [mailto:chris at chris-wilson.co.uk]
> Sent: Friday, July 7, 2017 5:38 PM
> To: Dong, Chuanxiao <chuanxiao.dong at intel.com>; intel-
> gfx at lists.freedesktop.org
> Cc: intel-gvt-dev at lists.freedesktop.org; Dong, Chuanxiao
> <chuanxiao.dong at intel.com>; Auld, Matthew <matthew.auld at intel.com>;
> Zhenyu Wang <zhenyuw at linux.intel.com>
> Subject: Re: [PATCH] drm/i915: Fix the kernel panic when using aliasing ppgtt
>
> Quoting Chuanxiao Dong (2017-07-07 07:00:09)
> > The ppgtt should be get directly from i915_address_space *vm instead
> > of
> > vma->vm as in alias ppgtt case the vma->vm is not same with vm.
>
> And for consistency, also
>
> @@ -2242,7 +2242,7 @@ static void
> bxt_vtd_ggtt_insert_entries__BKL(struct i915_address_space *vm,
> enum i915_cache_level level,
> u32 unused) {
> - struct insert_entries arg = { vma->vm, vma, level };
> + struct insert_entries arg = { vm, vma, level };
>
> stop_machine(bxt_vtd_ggtt_insert_entries__cb, &arg, NULL); }
Good catch! Will send out v2 to include this.
Thanks
Chuanxiao
More information about the Intel-gfx
mailing list