[Intel-gfx] [PATCH 7/8] drm/i915: Add NV12 as supported format for sprite plane

Clint Taylor clinton.a.taylor at intel.com
Mon Jul 10 17:59:13 UTC 2017



On 07/09/2017 11:53 PM, Vidya Srinivas wrote:
> From: Chandra Konduru <chandra.konduru at intel.com>
>
> This patch adds NV12 to list of supported formats for sprite plane.
>
> v2: Rebased (me)
>
> v3: Review comments by Ville addressed
> 	- Removed skl_plane_formats_with_nv12 and added
> 	NV12 case in existing skl_plane_formats
> 	- Added the 10bpc RGB formats
>
> v4: Addressed review comments from Clinton A Taylor
> 	"Why are we adding 10 bit RGB formats with the NV12 series patches?
> 	Trying to set XR30 or AB30 results in error returned even though
> 	the modes are advertised for the planes"
> 	- Removed 10bit RGB formats added previously with NV12 series
>
> Signed-off-by: Chandra Konduru <chandra.konduru at intel.com>
> Signed-off-by: Nabendu Maiti <nabendu.bikash.maiti at intel.com>
> Signed-off-by: Vidya Srinivas <vidya.srinivas at intel.com>
> ---
>   drivers/gpu/drm/i915/intel_sprite.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_sprite.c b/drivers/gpu/drm/i915/intel_sprite.c
> index 9a6b011..a48e5f8 100644
> --- a/drivers/gpu/drm/i915/intel_sprite.c
> +++ b/drivers/gpu/drm/i915/intel_sprite.c
> @@ -1060,8 +1060,6 @@ int intel_sprite_set_colorkey(struct drm_device *dev, void *data,
>   	DRM_FORMAT_ARGB8888,
>   	DRM_FORMAT_XBGR8888,
>   	DRM_FORMAT_XRGB8888,
> -	DRM_FORMAT_XBGR2101010,
> -	DRM_FORMAT_ABGR2101010,
>   	DRM_FORMAT_YUYV,
>   	DRM_FORMAT_YVYU,
>   	DRM_FORMAT_UYVY,
> @@ -1074,10 +1072,13 @@ int intel_sprite_set_colorkey(struct drm_device *dev, void *data,
>   	DRM_FORMAT_ARGB8888,
>   	DRM_FORMAT_XBGR8888,
>   	DRM_FORMAT_XRGB8888,
> +	DRM_FORMAT_XBGR2101010,
> +	DRM_FORMAT_ABGR2101010,

These are still present? This patch mistakingly removed them from 
vlv_plane_formats.

-Clint

>   	DRM_FORMAT_YUYV,
>   	DRM_FORMAT_YVYU,
>   	DRM_FORMAT_UYVY,
>   	DRM_FORMAT_VYUY,
> +	DRM_FORMAT_NV12,
>   };
>   
>   struct intel_plane *



More information about the Intel-gfx mailing list