[Intel-gfx] [PATCH] fbdev: Nuke FBINFO_MODULE

Bartlomiej Zolnierkiewicz b.zolnierkie at samsung.com
Wed Jul 12 12:54:11 UTC 2017


On Wednesday, July 12, 2017 02:42:14 PM Daniel Vetter wrote:
> On Wed, Jul 12, 2017 at 12:41:34PM +0200, Bartlomiej Zolnierkiewicz wrote:
> > On Tuesday, July 11, 2017 04:52:19 PM Daniel Vetter wrote:
> > > Instead check info->ops->owner, which amounts to the same.
> > > 
> > > Spotted because I want to remove the pile of broken and cargo-culted
> > > fb_info->flags assignments in drm drivers.
> > > 
> > > v2: Fixup matrox (reported by kbuild). Also nuke FBINFO_FLAG_* defines
> > > that I've failed to spot.
> > > 
> > > v3: Don't nuke FBINFO_FLAG_DEFAULT, that's used all over the place.
> > > 
> > > Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie at samsung.com>
> > > Cc: linux-fbdev at vger.kernel.org
> > > Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>
> > 
> > Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie at samsung.com>
> 
> Do you plan to pick these two patches up yourself, or do you expect me to
> merge them?

Since the original patchset contained DRM changes (two last patches)
depending on fbdev changes (two first patches, the patch being discussed
was the second one) I assumed that you would like to take them all
through DRM tree. If this is not what is preferred, please tell me.

> I'm always confused when the official maintainer acks something without
> saying anything else ...

Point taken, I will try to be more verbose next time.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics



More information about the Intel-gfx mailing list