[Intel-gfx] [PATCH i-g-t] tests/drm_module_reload: Don't require hda dynamic debug
Pandiyan, Dhinakaran
dhinakaran.pandiyan at intel.com
Fri Jul 14 21:03:48 UTC 2017
On Fri, 2017-07-14 at 19:14 +0200, Daniel Vetter wrote:
> I can live without those logs, and it avoids a kernel
> recompile&reboot.
>
Sounds reasonable, having hda dynamic debug does not feel like a
necessity for module_reload testing.
Reviewed-by: Dhinakaran Pandiyan <dhinakaran.pandiyan at intel.com>
> Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>
> ---
> tests/drv_module_reload.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tests/drv_module_reload.c b/tests/drv_module_reload.c
> index db2ad2cf0f43..be831851dec2 100644
> --- a/tests/drv_module_reload.c
> +++ b/tests/drv_module_reload.c
> @@ -285,7 +285,10 @@ hda_dynamic_debug(bool enable)
> const char snd_hda_core_off[] = "module snd_hda_intel =_";
>
> fp = fopen("/sys/kernel/debug/dynamic_debug/control", "w");
> - igt_assert(fp != NULL);
> + if (!fp) {
> + igt_debug("hda dynamic debug not available\n");
> + return;
> + }
>
> if (enable) {
> fwrite(snd_hda_intel_on, 1, sizeof(snd_hda_intel_on), fp);
More information about the Intel-gfx
mailing list