[Intel-gfx] [PATCH i-g-t] CONTRIBUTING: formalize review rules

[Daniel Vetter]

On Wed, Jul 19, 2017 at 11:03:46AM +0300, Arkadiusz Hiler wrote:
> On Tue, Jul 18, 2017 at 06:00:20PM +0200, Daniel Vetter wrote:
> > There's a bunch of reasons why I think we should formalize and enforce
> > our review rules for igt patches:
> > 
> > - We have a lot of new engineers joining and review helps enormously
> >   with mentoring and learning. But right now only patches from
> >   contributors without commit rights are consistently subjected to
> >   review, which makes this imbalanced and removes senior contributors
> >   from the review pool.
> > 
> > - We have a much bigger team and we need to make sure we're aligned on
> >   where igt as a tool and testsuite needs to head towards. Getting
> >   that alignment happens through reviewing each other's submission.
> >   Pushing a contentious patch and then dealing with a heated irc
> >   discussion is much less effective.
> > 
> > - Finally igt becomes ever more important for our testing, making sure
> >   the code quality is high is important. Review helps with that.
> > 
> > v2: Improve wording a bit (Imre).
> > 
> > Acked-by: Daniel Stone <daniels at collabora.com>
> > Acked-by: Jani Nikula <jani.nikula at intel.com>
> > Acked-by: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
> > Acked-by: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
> > Acked-by: Petri Latvala <petri.latvala at intel.com>
> > Acked-by: Imre Deak <imre.deak at intel.com>
> > Acked-by: Robert Foss <robert.foss at collabora.com>
> > Acked-by: Ben Widawsky <ben at bwidawsk.net>
> > Acked-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> > Acked-by: Mika Kuoppala <mika.kuoppala at intel.com>
> > Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>
> Acked-by: Arkadiusz Hiler <arkadiusz.hiler at intel.com>
> 
> With the recent growth in contributions it's a good thing :-)

And pushed, thx everyone for their acks.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch