[Intel-gfx] [PATCH 08/15] drm/i915: Clear execlist port[] before updating seqno on wedging

Chris Wilson chris at chris-wilson.co.uk
Thu Jul 20 13:54:19 UTC 2017


Quoting Mika Kuoppala (2017-07-20 14:31:31)
> Chris Wilson <chris at chris-wilson.co.uk> writes:
> 
> > When we wedge the device, we clear out the in-flight requests and
> > advance the breadcrumb to indicate they are complete. However, the
> > breadcrumb advance includes an assert that the engine is idle, so that
> > advancement needs to be the last step to ensure we pass our own sanity
> > checks.
> 
> I am confused about this one. The previous patch seems to make
> the concern void.

Yeah, I moved the assert around, but still felt the order imposed by
the memory of that assert was better.
-Chris


More information about the Intel-gfx mailing list